Fix launch_static_server script when only HTTP is wanted #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have "performance" tests which allow to ensure that we're not having what we could call "performance regressions", such as a higher delay to have a content loaded from a `loadVideo` call. I wanted to run them yesterday for #1607, but they hanged indefinitely. Turns out that our static server script, that we use here just to host and serve our testing scripts returned a promise that was never resolved. _(Note: we don't rely on external test runners nor on test frameworks for our performance tests, we manually detect and launch local chrome + firefox binaries on a local server serving our bundled scripts (themselves importing the RxPlayer), and at runtime those scripts send results to another "result" server when they're done)_ It was never resolved because we never properly handled the case in that script were we wanted to launch an HTTP server but not an HTTPS one for the same resource(s). This is now fixed. Hopeful that performance tests now work correctly, it's been a long time since I last ran them.
peaBerberian
added
bug
Florent-Bouisset
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have "performance" tests which allow to ensure that we're not having what we could call "performance regressions", such as a higher delay to have a content loaded from a
loadVideocall.I wanted to run them yesterday for #1607, but they hanged indefinitely.
Turns out that our static server script, that we use here just to host and serve our testing scripts returned a promise that was never resolved.
(Note: we don't rely on external test runners nor on test frameworks for our performance tests, we manually detect and launch local chrome + firefox binaries on a local server serving our bundled scripts (themselves importing the RxPlayer), and at runtime those scripts send results to another "result" server when they're done)
It was never resolved because we never properly handled the case in that script were we wanted to launch an HTTP server but not an HTTPS one for the same resource(s). This is now fixed.
Hopeful that performance tests now work correctly, it's been a long time since I last ran them.